>>>>> On Wed, 06 Apr 2022, Thomas Bracht Laumann Jespersen wrote:

> -             find $d/doc -name \*.txt -type l | while read s; do
> -                     [[ $(readlink "$s") = $vimfiles/* ]] && rm -f "$s"
> +             find ${d}/doc -name \*.txt -type l | while read s; do
> +                     [[ $(readlink "${s}") = $vimfiles/* ]] && rm -f "${s}"

This would profit from a "|| die" statement.

> -                     einfo "Removing $d"
> -                     rm -r "$d"
> +                     einfo "Removing ${d}"
> +                     rm -r "${d}"

Ditto.

> -             if [[ -d $vimfiles/doc ]]; then
> -                     ln -s $vimfiles/doc/*.txt $d/doc 2>/dev/null
> +             if [[ -d "${vimfiles}"/doc ]]; then
> +                     ln -s "${vimfiles}"/doc/*.txt "${d}/doc" 2>/dev/null

Ditto.

Ulrich

Reply via email to