On Fri, Aug 5, 2022 at 7:15 PM Ionen Wolkens <io...@gentoo.org> wrote: > > On Fri, Aug 05, 2022 at 06:47:42PM -0400, Mike Pagano wrote: > > Based upon code from check-reqs.eclass by Andreas Sturmlechner > > > > Provide support for users who requested the ability to skip > > CONFIG_* checks. (e.g. from within a chroot for testing purposes) > > > > Bug: https://bugs.gentoo.org/862315 > > Signed-off-by: Mike Pagano <mpag...@gentoo.org> > > --- > > eclass/linux-info.eclass | 11 ++++++++++- > > 1 file changed, 10 insertions(+), 1 deletion(-) > > > > diff --git a/eclass/linux-info.eclass b/eclass/linux-info.eclass > > index 7e130062a..59e86490f 100644 > > --- a/eclass/linux-info.eclass > > +++ b/eclass/linux-info.eclass > > @@ -29,6 +29,15 @@ > > # A Couple of env vars are available to effect usage of this eclass > > # These are as follows: > > > > + > > +# @ECLASS_VARIABLE: CHECKCONFIG_DONOTHING > > +# @USER_VARIABLE > > +# @DEFAULT_UNSET > > +# @DESCRIPTION: > > +# Do not error out in check_extra_config if CONFIG settings are not met. > > +# This is a user flag and should under _no circumstances_ be set in the > > ebuild. > > +[[ -n ${I_KNOW_WHAT_I_AM_DOING} ]] && CHECKCONFIG_DONOTHING=1 > > So this enables it if I_KNOW_WHAT_I_AM_DOING is set? > > Generally I feel giving more purposes to that variable is a bad idea. > What starts out as "don't bother me about size/ram checks" ignores > a lot of other things that may be not be expected.
I agree. Please avoid abusing the I_KNOW_WHAT_I_AM_DOING variable any further.
