Jaco Kroon <j...@uls.co.za> writes:
> Hi, > > On 2024/01/09 13:42, Michał Górny wrote: >> On Tue, 2024-01-09 at 12:54 +0200, Jaco Kroon wrote: >>> https://github.com/gentoo/gentoo/pull/34126 ?? >>> >>> Perhaps I'm missing something if you say it's non-trivial but we're >>> using that on 9 hosts currently. >>> >> Do tests pass for you? https://bugs.gentoo.org/879181#c2 indicated that >> they do not. > > How critical is it that they do? > > Even for the bump PR they do not, they fail with the below, and > frankly my knowledge of ruby is outright scary. The below to me > indicates that the tests are designed specifically to run from a git > checkout, there are two possible "fixes": > > 1. patch the code to not require this. > 2. disable tests. > >>>> Test phase: app-admin/fluentd-1.16.3 > * Running test phase for ruby31 > [...] > [...] > <internal:/usr/lib64/ruby/site_ruby/3.1.0/rubygems/core_ext/kernel_require.rb>:85:in > `require': cannot load such file -- rr (LoadError) Try adding a test dep on dev-ruby/rr. Anyway, if it works for you in production, and you're willing to (reluctantly) adopt it, then we can work on the tests later.
