On 29/02/2024 15.08, Michael Orlitzky wrote:
On Thu, 2024-02-29 at 14:47 +0100, Florian Schmaus wrote:
+if [[ -z ${TL_PV} ]] \
+          && [[ ${EAPI} -ge 8 ]] \

I am skeptical of this construct, as in the past we had non-numeric
EAPIs. So I may have to go with EAPI == 8 for now. Input appreciated.



The eclass only supports EAPIs {7,8,...} so it should suffice to
blacklist EAPI=7.

Fair point, but that would mean to remember to adjust this line once the eclass gets support for EAPI 9.

It appears that bash does the right thing:

$ if [[ "eapi-future" -gt 8 ]]; then echo "is greater than 8"; else echo "is NOT greater than 8"; fi
is NOT greater than 8

even considering

$ if [[ "9-eapi-future" -gt 8 ]]; then echo "is greater than 8"; else echo "is NOT greater than 8"; fi
is greater than 8

which would be fine.

Although I prefer the current approach, it is not a hill to die on for me.

- Flow

Attachment: OpenPGP_0x8CAC2A9678548E35.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature

Reply via email to