On Tue, Aug 16, 2005 at 02:39:36PM -0400, Alec Joseph Warner wrote:
> I kind of see Brian's point in being defensive in filenames though
> (os.path.normpath("///////var/db/pkg/fex") being invalid in a CONTENTS
> file but still usable by most(?) calls in python, which will just figure
> it all out anyway.
If we aren't defensive on it, and it causes something to implode, it's
a runtime bt...
Re: equery, equery is a special case walking the entire contents...> If portage errored on invalid paths in CONTENTS file, I would see > leaving it there, but if it doesn't help anything ( because it doesn't > hurt anything either, right? :) ) then why do the work? What about finding a faster approach then normpath? Take a look at normpath, it splits it up into strings, and rejoins; that's a bit of a hit right there- potential point for optimization if I keep screaming "the data returned may not be right, albeit usable" :) ~harring
pgpYl7htd0bwL.pgp
Description: PGP signature
