> On Sun, Aug 28, 2005 at 02:46:28PM +0900, Jason Stubbs wrote: >> On Saturday 27 August 2005 19:53, Brian Harring wrote: >> > Please test this out; if you want to test the EAPI checking, tag >> > EAPI=1 into an ebuild, and try making emerge bail. >> >> + print "EAPI check, unknown source "+str(x[0])+" for "+x[2]+", this >> shouldn't occur",mylist >> + sys.exit(1) >> >> These two are in the patch. Can that be made an exception please? That >> way >> --debug could still be useful if the bug hits. > That's debugging; not knowing (due to design flaws) all potentials for > x[0], stuck that in debugging for anyone running the patch; people > hitting it reporting back (hopefully), for debugging > > Final version won't include it. > ~harring >
pppfft, you were just complaining about all the sys.exit()'s in the code and then you go and add one yourself. raise something instead, even if it's just an Exception, that way it saves anyone from grepping through the code for the error message. -Alec PS: Squirrelmail sucks for actual work :P -- [email protected] mailing list
