On Wed, 2005-09-21 at 08:46 +0900, Jason Stubbs wrote:
> > Updated patch to add a semaphore to control access to the global
> > portage.config object. Unless anyone sees any other issues with this
> > patch, I will be placing it into gentoolkit.
> 
> Is the settingslock created in __init__.py accessible in package.py? It may 
> just be another gem of python I didn't know about, but wouldn't it be not 
> available from that scope?
> 

It's available due to the ugly "from gentoolkit import *" at the start
of the file.

> Also, the calling of self._settings.reset() would be a big performance hit. 
> setcpv() does almost nothing if the per-package settings of the passed cpv 
> are identical to those of the previous. reset() on the other hand restacks 
> all configuration every time.

I hadn't noticed a big performance hit, but it is easily removed.

Regards,
Paul
-- 
gentoo-portage-dev@gentoo.org mailing list

Reply via email to