On Fri, Oct 28, 2005 at 11:38:56PM -0700, Zac Medico wrote: > Jason Stubbs wrote: > >On Saturday 29 October 2005 13:20, Jason Stubbs wrote: > > > >>I've adjusted the patch a bit to make all method signature changes into > >>keyword arguments. I've also change the default tree to None and added a > >>warning message to doebuild when None is passed and defaulting it to tree > >>there. With the EAPI changes, passing a tree is really a requirement. If a > >>tree isn't passed, it'd be better to alert people to that rather than > >>trying to backtrack to it as the cause of the bugs that will inevitably > >>pop > >>up. > > > > > >Many usages of doebuild in emerge - one of which wasn't meant to go to > >"porttree". The warning has helped already! ;) > > > >Cleaned up those instances and also fixed a typo (of mine) in > >portage.unmerge(). > > > > I'm using your new patch an it looks good. Nice idea to place that warning > in there. I did a recursive grep and found a couple doebuild calls that > will generate a warning (see patch). It looks like you're about ready to > package up an _rc7 that hopefully will become stable soon. :) I'd wrap it to the end of the output personally, since a traceback can get a bit long sometimes if there is a lot of frames on the stack.
Aside from that suggestion, no complaints; .53 material, or .54? ~harring
pgpqzrcfiMPn6.pgp
Description: PGP signature
