On Fri, 2007-02-09 at 06:51 +0000, Alec Warner wrote:
> In order to facilitate better ease of use with phase hooks, I propose a 
> paludis-style default phase hook.  Basically ebuild.sh provides a default 
> hook that looks in PORTAGE_HOOKS_DIR/{pre,post}_${EBUILD_PHASE}/ for shell 
> scripts and sources them.
What is PORTAGE_HOOKS_DIR?  Where is it set?

> ...
> Comments and Questions are welcome.
The quoting doesn't seem quite right.  Assuming you intend to expand the
glob at define time, it should be
+       eval "${prefix}_${EBUILD_PHASE}() {
+               for script in 
\"${PORTAGE_HOOKS_DIR}/${prefix}_${EBUILD_PHASE}/\"*.sh
+               do
+                       ebegin \"Sourcing \$script\"
+                       qa_source \$script || die \"Failed to source \$script\"
+                       eend
+               done
+       }"

Ed

-- 
gentoo-portage-dev@gentoo.org mailing list

Reply via email to