2013-10-17 04:53 Mike Frysinger napisał(a): > On Wednesday 16 October 2013 22:51:17 Mike Frysinger wrote: > > On Wednesday 16 October 2013 20:02:50 Arfrever Frehtes Taifersar Arahesis > > > > wrote: > > > 2013-10-16 23:03 Mike Frysinger napisał(a): > > > > Rather than each module implementing its own shim around the various > > > > methods for accessing extended attributes, start a dedicated module > > > > that exports a consistent API. > > > > > > Some things are incompatible with Python 3. > > > See other comments below. > > > > i can run a linter on the code (probably should make this a git hook). i'm > > interested more in review on the bigger picture. > > also, none of your comments were py3 issues that i saw
I said "other comments", so I meant comments not related to incompatibility with Python 3. About incompatibility with Python 3: - subprocess.check_output(), subprocess.Popen().stdout.read(), subprocess.Popen().stderr.read() return bytes, which is incorrectly compared with str in your patches. - dict.iteritems() was renamed to dict.items() (and its return type was changed from dictionary-itemiterator to dict_items, but it does not matter here). - Queue module was renamed to queue. - cStringIO module should not be used. io module is a replacement available since Python 2.6. - Maybe other problems... -- Arfrever Frehtes Taifersar Arahesis
signature.asc
Description: This is a digitally signed message part.
