In reply, you will find three repoman patches; PATCH 1 is a bit more complex
which I will detail here, the other two patches should be fairly trivial.
In the first patch I need to use the @system set, as I only want to check
DEPEND for packages not in the @system set; thus here is kept in mind that
the @system set could possible change, in which case the check continues to
work. After checking up with Arfrever, a first version that I came up with is
> +from portage._sets.profiles import PackagesSystemSet
> +system_set_atoms = PackagesSystemSet(portage.settings.profiles).getAtoms()
but I am not sure if this is appropriate when used in other repositories.
Arfrever warned me about this but I think I do not fully understand that.
Both archive_formats* variables are based on the PMS specifications.
The rest of the code has comments and should be trivial to understand.
For the check name we came up with "unpack.DEPEND.missing"; most of the
checks are two words, so, I don't know if three words is permitted. At least
repoman runs without complaining or bailing out because of this.
There's still a TODO left in the code that leaves me in doubt on how to
properly ask the keywords to Portage; seems that I still need to learn to
find my way through the documentation, but I guess after getting pointed to
it a few times it will become easier.
These are my first patches to the Repoman code, all three patches introduce a
new warning / error, therefore it might be possible that I missed something.
Grepping on an existing warning I saw the man page needs to be updated; since
I never did that before, feel free to check if the syntax of that is right.
Thank you for taking your time to review these.
--
bin/repoman | 63 ++++++++++++++++++++++++++++++++++++++++++++++++
+++++++++++++++
man/repoman.1 | 10 ++++++++++
pym/repoman/checks.py | 10 ++++++++++
3 files changed, 83 insertions(+)
[PATCH 1/3] Have repoman check if the packages to unpack rare archive
formats from SRC_URI are present in DEPEND (bug #205909).
[PATCH 2/3] Have repoman check that a package directory contains at least
one ebuild (bug #245305).
[PATCH 3/3] Have repoman deprecate G2CONF for the GNOME team. (bug #482084).
--
With kind regards,
Tom Wijsman (TomWij)
Gentoo Developer
E-mail address : tom...@gentoo.org
GPG Public Key : 6D34E57D
GPG Fingerprint : C165 AF18 AB4C 400B C3D2 ABF0 95B2 1FCD 6D34 E57D
