-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 These look good. ACK on 1 and 2 from me, but I would like Sebastian, Arfrever, Brian, or someone else at least to look over them. These patches are too "interesting" to be pushed after a single ACK.
For 3, I think it looks nice but you should check with Brian & Tom about whether to put it in now or in the refactor branch. Also, please ask QA about it so we don't get another bikeshed marathon to deal with. Lastly, I think the commit message of the first commit is very poorly worded, but we've discussed that on IRC. Ping me there for more details if you want. Thanks for doing this! - -- Alexander berna...@gentoo.org https://secure.plaimi.net/~alexander -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iF4EAREIAAYFAlPr1B4ACgkQRtClrXBQc7VG7gEAllXiY0FUKn+5dUajk/tiZoj/ 3H3KW9MPfmfeMh0Dnv8BAJX+y8hsBnppm9W+ap8VfzkrxGeme6J6VSAdYCQd+Dea =VX87 -----END PGP SIGNATURE-----
