On Wed, 14 Jan 2015 15:26:49 -0800 Zac Medico <zmed...@gentoo.org> wrote:
> On 12/23/2014 12:45 PM, Zac Medico wrote: > > The @changed-deps set is useful, but it has limitations similar to > > the @installed set (see bug #387059), which can make it unsuitable > > for use when updating the whole system. Therefore, implement two > > new options that are analogous to --newuse and > > --binpkg-respect-use, called --changed-deps and > > --binpkg-changed-deps. > > > > The rationale for having a separate --binpkg-* option is the same in > > both cases: depending on the situation, people may want different > > behavior for binary packages. For example, just like > > ---binpkg-respect-use is automatically enabled if the user has not > > specified --usepkgonly, so is --binpkg-changed-deps (though the user > > can explicitly override the automatic behavior). In both cases, > > inconsistencies in dependencies are automatically avoided, > > increasing the probability of a successful dependency calculation. > > > > X-Gentoo-Bug: 282927 > > X-Gentoo-Bug-URL: https://bugs.gentoo.org/show_bug.cgi?id=282927 > > --- > > man/emerge.1 | 22 +++- > > pym/_emerge/create_depgraph_params.py | 16 +++ > > pym/_emerge/depgraph.py | 138 > > ++++++++++++++++++++++-- > > pym/_emerge/main.py | 26 +++++ > > pym/portage/dep/_slot_operator.py | 13 +++ > > pym/portage/tests/resolver/test_changed_deps.py | 120 > > +++++++++++++++++++++ 6 files changed, 323 insertions(+), 12 > > deletions(-) create mode 100644 > > pym/portage/tests/resolver/test_changed_deps.py > > Any feedback on this? I think it's good to merge. yeah, looks good, merge approved :) -- Brian Dolbec <dolsen>