On 30 May 2015 11:22, Zac Medico wrote: > On 05/30/2015 07:36 AM, Mike Frysinger wrote: > > On 26 May 2015 08:58, Zac Medico wrote: > >> On 05/26/2015 07:24 AM, Mike Frysinger wrote: > >>> + # Only check on 32-bit systems. Filtering by $ARCH here isn't perfect, > >>> but > >>> + # it should be good enough for our needs. > >>> + case ${ARCH} in > >>> + arm|mips|ppc|sh|x86) ;; > >>> + *) return ;; > >>> + esac > >> > >> Shouldn't we also enable this for 64-bit archs when multilib is enabled? > > > > yes, but i think we should start here first. getting multilib right is > > kind of > > a pain. this should give us enough coverage i think to get people to start > > filing bugs which implicitly covers multilib users. once the dust has > > settled, > > we can look at expanding the multilib coverage. although that would really > > require a python implementation, and the current install hooks logic > > implicitly > > requires every file to be bash. > > > > to use your pkg-config example, it installs 32bit & 64bit ELFs into > > /usr/bin. > > we can't scan all 32bit ELFs because it would incorrectly flag ILP32 ABIs > > like > > x32 & n32. > > Our compute_multilib_category function has logic that could be used to > separate and filter them: > > https://gitweb.gentoo.org/proj/portage.git/tree/pym/portage/dep/soname/multilib_category.py
that'd require a python implementation which hooks are somewhat limited by currently ;) -mik
signature.asc
Description: Digital signature