On 06/10/2015 10:39 PM, Mike Frysinger wrote: > On 10 Jun 2015 11:54, Zac Medico wrote: >> On 05/30/2015 01:59 PM, Mike Frysinger wrote: >> LGTM, except this one line is indented with spaces instead of tabs in >> vartree.py: >> >>> def tar_contents(contents, root, tar, protect=None, onProgress=None, >>> - xattr=False): >>> + xattrs=False): > > i don't know if we have a standard here. sometimes it's a single tab, > sometimes > it's spaces to line up. i prefer the latter as that's generally what PEP8 > does. > -mike >
Ah, ok. The test pass, so guess it's fine that way. -- Thanks, Zac
