On 05/07/2016 04:38 AM, Alexander Berntsen wrote: > Still barely readable without putting it in git and getting colours. > Which tells me this should probably not look the way it looks at > present...
Yeah, we could certainly split the code out into standalone shell scripts and install them in sub-directory of $PORTAGE_BIN_PATH. The code makes a good test case for make.* parsing with respect to quoting and multiple layers of escapes, so maybe we should keep something similar in the unit tests. The code was sort of a quick and dirty fix that was never really intended to be readable, which may have contributed to the 2+ years that went by before someone got around to writing a patch. > But it looks like it's doing what it's supposed to be doing. So go > ahead and push. > > I think the message title is about a billion characters above budget, > so perhaps just make it "make.globals: Respect ssh_config port (bug > 499198)" or something; your call though. Thanks, I've pushed it with your shorter commit message. -- Thanks, Zac
