On 11/01/2017 09:31 AM, Brian Dolbec wrote: > On Tue, 24 Oct 2017 11:41:37 -0700 > Zac Medico <zmed...@gentoo.org> wrote: > >> The sendfile *offset parameter refers to the input file offest, so >> it cannot be used in the same way as the copy_file_range *off_out >> parameter. Therefore, add sf_wrapper function which implements the >> *off_out behavior for sendfile. >> >> Also update cfr_wrapper so that it does not rely on the fd_in file >> offset, and remove corresponding fd_in lseek calls which are no >> longer needed. >> >> The file offset of fd_in is now completely unused, except in the >> plain read/write loop, where lseek is called prior to entering >> the loop. >> >> Bug: https://bugs.gentoo.org/635126 >> --- >> [PATCH v5] eliminates all reliance on the file offset of fd_in, >> except in the plain read/write loop, where lseek is called prior >> to entering the loop. >> >> src/portage_util_file_copy_reflink_linux.c | 88 >> ++++++++++++++++++++---------- 1 file changed, 59 insertions(+), 29 >> deletions(-) > > > Looks good, has been checked by chutzpah >
Thanks, merged: https://gitweb.gentoo.org/proj/portage.git/commit/?id=5b6cf172e378f6da88e9634aa4e89f2f34390659 -- Thanks, Zac
signature.asc
Description: OpenPGP digital signature