On 02/04/2018 07:22 PM, R0b0t1 wrote:
> This is everything that shellcheck reported as an error. They are not
> as serious as the globbing issue, but it would be a good idea to
> change them. They are generally "type" issues (e.g. ">" instead of
> "-gt").
>
> Some changes are shellcheck annotations. Very interesting was:
>
> eval "$x=(\"\${$x[@]}\" ${QA_PREBUILT//\*/.*})"
>
> Which looks like a bad array expansion ("$x[@]").
I don't see a shellcheck error for that, using shellcheck-0.4.7. Maybe a
false positive with an older version?
> diff --git a/bin/isolated-functions.sh b/bin/isolated-functions.sh
> index b28e44f18..377b32d90 100644
> --- a/bin/isolated-functions.sh
> +++ b/bin/isolated-functions.sh
> @@ -82,7 +82,7 @@ __dump_trace() {
> lineno=${BASH_LINENO[${n} - 1]}
> # Display function arguments
> args=
> - if [[ -n "${BASH_ARGV[@]}" ]]; then
> + if [[ -n "${BASH_ARGV[*]}" ]]; then
I feel like the shellcheck authors might be willing to accept [[ -n
${BASH_ARGV[@]} ]] or [[ ${BASH_ARGV[@]} ]] as correct, since the
"Problematic code" that they cite involves an incorrect comparison:
https://github.com/koalaman/shellcheck/wiki/SC2199#problematic-code
I've merged all of your other changes. Thanks!
--
Thanks,
Zac
signature.asc
Description: OpenPGP digital signature
