On 02/07/2018 01:46 AM, Michał Górny wrote: > diff --git a/pym/portage/xml/metadata.py b/pym/portage/xml/metadata.py > index 9e48dddde..99e0474c1 100644 > --- a/pym/portage/xml/metadata.py > +++ b/pym/portage/xml/metadata.py > @@ -1,4 +1,4 @@ > -# Copyright 2010-2017 Gentoo Foundation > +# Copyright 2010-2018 Gentoo Foundation > # Distributed under the terms of the GNU General Public License v2 > > """Provides an easy-to-use python interface to Gentoo's metadata.xml file. > @@ -8,8 +8,6 @@ > >>> pkg_md = > MetaDataXML('/usr/portage/app-misc/gourmet/metadata.xml') > >>> pkg_md > <MetaDataXML '/usr/portage/app-misc/gourmet/metadata.xml'> > - >>> pkg_md.herds() > - ['no-herd'] > >>> for maint in pkg_md.maintainers(): > ... print "{0} ({1})".format(maint.email, maint.name) > ... > @@ -198,13 +196,11 @@ class _Upstream(object): > class MetaDataXML(object): > """Access metadata.xml""" > > - def __init__(self, metadata_xml_path, herds): > + def __init__(self, metadata_xml_path):
For backward compatibility, lets make herds an unused herds=DeprecationWarning keyword argument. Otherwise, the patch looks good. -- Thanks, Zac
signature.asc
Description: OpenPGP digital signature