On 09-01-2019 21:22:26 -0800, Zac Medico wrote:
> > + if tnow + tinterv < ninterv:
> > + showMessage(_("100% done\n"))
>
> It took me a moment to understand the calculation here. How about if we
> do something like this instead:
>
>
> previous = monotonic()
> progress_shown = False
You're right. I should've gone for readability in the first place.
There is no point in trying to save anything here.
Thanks,
Fabian
> for f in files:
> current = monotonic()
> if current - previous > tinterv:
> showMessage(...)
> previous = current
> progress_shown = True
>
> if progress_shown:
> showMessage(_("100% done\n"))
>
>
>
> > return collisions, dirs_ro, symlink_collisions,
> > plib_collisions
> >
> > def _lstat_inode_map(self, path_iter):
> >
>
>
> --
> Thanks,
> Zac
>
--
Fabian Groffen
Gentoo on a different level
signature.asc
Description: PGP signature
