On 8/2/19 9:06 AM, Mike Gilbert wrote: > Bug: https://bugs.gentoo.org/691290 > Signed-off-by: Mike Gilbert <flop...@gentoo.org> > --- > lib/portage/process.py | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/lib/portage/process.py b/lib/portage/process.py > index 77f7fac02..4d5a42a8c 100644 > --- a/lib/portage/process.py > +++ b/lib/portage/process.py > @@ -478,7 +478,9 @@ def _configure_loopback_interface(): > > try: > subprocess.call(['ip', 'address', 'add', '10.0.0.1/8', 'dev', > 'lo']) > - subprocess.call(['ip', 'address', 'add', 'fd00::1/8', 'dev', > 'lo']) > + with open('/dev/null', 'wb') as devnull: > + subprocess.call(['ip', 'address', 'add', 'fd00::1/8', > 'dev', 'lo'], > + stdout=devnull, stderr=devnull) > except OSError as e: > writemsg("Error calling 'ip': %s\n" % e.strerror, noiselevel=-1) > >
Looks good, but let's use the os.devnull constant. Please merge. -- Thanks, Zac
signature.asc
Description: OpenPGP digital signature
