On Sun, 2019-11-03 at 11:49 -0800, Zac Medico wrote: > On 10/27/19 10:40 AM, William Hubbs wrote: > > Most upstreams and build systems do not make this distinction, so this > > causes unnecessary hacks in ebuilds. > > > > Signed-off-by: William Hubbs <willi...@gentoo.org> > > --- > > bin/install-qa-check.d/80libraries | 10 ---------- > > 1 file changed, 10 deletions(-) > > > > diff --git a/bin/install-qa-check.d/80libraries > > b/bin/install-qa-check.d/80libraries > > index d1d2c4fdd..e59369bf6 100644 > > --- a/bin/install-qa-check.d/80libraries > > +++ b/bin/install-qa-check.d/80libraries > > @@ -152,16 +152,6 @@ lib_check() { > > done > > [[ ${abort} == "yes" ]] && die "add those ldscripts" > > > > - # Make sure people don't store libtool files or static libs in /lib > > - f=$(ls "${ED%/}"/lib*/*.{a,la} 2>/dev/null) > > - if [[ -n ${f} ]] ; then > > - __vecho -ne '\n' > > - eqawarn "QA Notice: Excessive files found in the / partition" > > - eqawarn "${f}" > > - __vecho -ne '\n' > > - die "static archives (*.a) and libtool library files (*.la) > > belong in /usr/lib*, not /lib*" > > - fi > > - > > # Verify that the libtool files don't contain bogus $D entries. > > local abort=no gentoo_bug=no always_overflow=no > > for a in "${ED%/}"/usr/lib*/*.la ; do > > > > Merged. Thanks! > > https://gitweb.gentoo.org/proj/portage.git/commit/?id=498900e5e51460502d8271f409a4c614a021613b >
Please revert this. I should point out that this has been vetoed by a QA member, and is currently subject to QA vote. Therefore, I believe you shouldn't be making rash decisions based on patches submitted by a single developer. Especially given that so far nobody else has voiced his opinion either way, so it's 1:1. -- Best regards, Michał Górny
signature.asc
Description: This is a digitally signed message part