On 2/20/20 9:36 PM, Michael 'veremitz' Everitt wrote: > On 21/02/20 05:29, Matt Turner wrote: >> I found the original code to be nearly incomprehensible. Instead of >> populating a dict of potential binpkgs to remove and then removing from >> the to-be-removed list, just selectively add to-be-removed packages. >> >> Signed-off-by: Matt Turner <matts...@gentoo.org> >> --- >> I switched from tabs to spaces in the process. I can revert back if >> desired. >> > Probably best to stick to tabs for consistency with the other portage code, > although naturally Zac probably better to ACK/NACK that.
Yeah lets stick with tabs unless we're converting everything to spaces. > Otherwise I think this is a good refresh. +1. Yes, looks good. -- Thanks, Zac