On 3/11/20 9:37 AM, Alec Warner wrote: > On Wed, Mar 11, 2020 at 12:16 AM Zac Medico <zmed...@gentoo.org > <mailto:zmed...@gentoo.org>> wrote: > > For files returned by git diff-index, call git update-index in order > to ensure that the index reflects the state on disk. This will prevent > incorrect assumptions in cases where the index is missing or stale for > some reason. Since repoman uses this information to decide when to > update copyright header dates, this can prevent spurious copyright > header updates. > > Signed-off-by: Zac Medico <zmed...@gentoo.org > <mailto:zmed...@gentoo.org>> > Bug: https://bugs.gentoo.org/712106 > --- > repoman/lib/repoman/modules/vcs/git/changes.py | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/repoman/lib/repoman/modules/vcs/git/changes.py > b/repoman/lib/repoman/modules/vcs/git/changes.py > index 7e9ac1eb5..ebf770d53 100644 > --- a/repoman/lib/repoman/modules/vcs/git/changes.py > +++ b/repoman/lib/repoman/modules/vcs/git/changes.py > @@ -29,8 +29,14 @@ class Changes(ChangesBase): > ''' > super(Changes, self).__init__(options, repo_settings) > > - def _scan(self): > - '''VCS type scan function, looks for all detectable > changes''' > + def _scan(self, _reindex=True): > > > Why the underscore prefix? > > -A
I can't think of a reason to use this parameter aside from this recursive call, and the underscore hints at this. -- Thanks, Zac
signature.asc
Description: OpenPGP digital signature
