On 3/11/20 9:36 PM, Matt Turner wrote:
> On Wed, Mar 11, 2020 at 9:31 PM Zac Medico <zmed...@gentoo.org> wrote:
>>> @@ -562,7 +575,16 @@ def findPackages(
>>>               # Exclude if binpkg exists in the porttree and not --deep
>>>               if not destructive and port_dbapi.cpv_exists(cpv):
>>> -                     continue
>>> +                     if not options['changed-deps']:
>>> +                             continue
>> We can't can't continue above, since that will skip all of the filters
>> that occur later in the loop. So, we have to nest the below changed-deps
>> code under if options['changed-deps']:
> I'm happy to make that change, but I don't think it's necessary,
> strictly speaking, since this is inside an 'if not destructive'
> conditional and the only filter afterwards is 'if destructive'.
> In case we add more filters in the future, I'll make the change you suggested.

Yeah, I think it significantly reduces the cognitive burden to the
reader as well. Thanks!

> Thanks a bunch for your reviews!

You're welcome!

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to