On 3/4/21 11:24 AM, Matt Turner wrote: > With no need to support Python 2, we can remove our private > implementation. > > Signed-off-by: Matt Turner <matts...@gentoo.org> > --- > I don't know how to test this. I intentionally broke the return value of > create_subprocess_exec and didn't see any bad results. > > lib/portage/util/futures/_asyncio/__init__.py | 8 +- > lib/portage/util/futures/_asyncio/process.py | 116 ------------------ > 2 files changed, 4 insertions(+), 120 deletions(-) > delete mode 100644 lib/portage/util/futures/_asyncio/process.py
Merged, thanks! https://gitweb.gentoo.org/proj/portage.git/commit/?id=1e843f853a9afe82d599e6ab09064147ddc1d271 > diff --git a/lib/portage/util/futures/_asyncio/__init__.py > b/lib/portage/util/futures/_asyncio/__init__.py > index 5590963f1..207e7205d 100644 > --- a/lib/portage/util/futures/_asyncio/__init__.py > +++ b/lib/portage/util/futures/_asyncio/__init__.py > @@ -25,6 +25,7 @@ import types > import weakref > > import asyncio as _real_asyncio > +from asyncio.subprocess import Process > > try: > import threading > @@ -138,7 +138,7 @@ def create_subprocess_exec(*args, **kwargs): > > result = loop.create_future() > > - result.set_result(_Process(subprocess.Popen( > + result.set_result(Process(subprocess.Popen( > args, > stdin=kwargs.pop('stdin', None), > stdout=kwargs.pop('stdout', None), The above area is actually no longer used, since we should always have a _AsyncioEventLoop instance here, and we can remove the EventLoop class now. -- Thanks, Zac
signature.asc
Description: OpenPGP digital signature