> On 26 Jul 2022, at 00:33, Mike Gilbert <flop...@gentoo.org> wrote: > > On Mon, Jul 25, 2022 at 11:38 AM Fabian Groffen <grob...@gentoo.org> wrote: >> >> bin/install-qa-check.d/80libraries: support Darwin/Mach-O objects >> >> Check for dylib on Darwin, so on everything else. >> >> Signed-off-by: Fabian Groffen <grob...@gentoo.org> >> >> diff --git a/bin/install-qa-check.d/80libraries >> b/bin/install-qa-check.d/80libraries >> index 8dc35bb87..a477ec9cb 100644 >> --- a/bin/install-qa-check.d/80libraries >> +++ b/bin/install-qa-check.d/80libraries >> @@ -140,7 +140,9 @@ lib_check() { >> local abort="no" >> local a s >> for a in "${ED%/}"/usr/lib*/*.a ; do >> - s=${a%.a}.so >> + [[ ${CHOST} == *-darwin* ]] \ >> + && s=${a%.a}.dylib \ >> + || s=${a%.a}.so > > I would find this much easier to read if you converted it to an > if/else statement instead of chaining && and ||.
Yes, please.
signature.asc
Description: Message signed with OpenPGP