On Tue, 2010-04-06 at 11:39 +0200, Javier Fernandez Garcia-Boente wrote: > On Thu, 2010-04-01 at 12:58 +0100, Simon McVittie wrote: > > > > Version 0.82. > > > > According to the release notes, error codes containing "-" were fixed in > > 0.86. > > > > Arg, i should have checked the dbus-glib bugzilla before sending the > email; im sorry, too eager to start contributing :) > > Anyway, don't you think that an exception like > "org.freedesktop.Geoclue.Error.not-implemented" is kind of weird ? Isn't > more homogeneous the one generated with the patch i sent before ? > > "org.freedesktop.Geoclue.Error.NotImplemented"
Your patch looks fine to me, though those changes would need to be made all the way across geoclue, not just in that location (I didn't check to see whether there were other error cases that would need to be handled). > Anyway, do you think Geoclue should require dbus-glibe version >= 0.84 ? > The error caused by the bug (or a not implemented feature) is very bad > for testing purposes. Im trying to fix the tests cases of the WebKitGtk > project for Geolocation and obviously, the unit tests do no start any > provider, so the geoclue-master crashes when using versions < 0.86, so > it makes all the tests fail. Requiring dbus-glib 0.86 would be a good idea either way. Cheers _______________________________________________ GeoClue mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/geoclue
