Am 24.06.2010 20:44, schrieb Javier Fernandez Garcia-Boente: > On Mon, 2010-06-21 at 13:32 +0200, Javier Fernandez Garcia-Boente wrote: >> On Thu, 2010-06-17 at 11:25 +0200, Javier Fernandez Garcia-Boente wrote: > >> >> <snip>
Thanks for the patch - just some small patch review: the docs for geoclue_position_set_position () say "geoclue_position_get_position" (set->get) Is the "accuracy" parameter in geoclue_position_set_position() meant to be GeoclueAccuracyLevel? If so please use that type and mybe consitently name the variable accuracy -> accuracy_level and also in the instance acc -> accuracy_level Should geoclue_manual_init() initialise "acc" too? Bit later it looks like "acc" is horizontal accuracy. That should then be double and maybe named accordingly. Stefan _______________________________________________ GeoClue mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/geoclue
