I know we don't have any official policies about review practices or whatever. But when a change is so hacky/tricky/whatever that you feel like you need to warn everyone about it, I'd appreciate posting it somewhere other than GeoNode/geonode for review first, rather than (effectively) asking for a review of something you already committed.
Not directly at Seb, this is just a good example of what I'm talking about. -- David Winslow OpenGeo - http://opengeo.org/ On 07/06/2010 05:07 PM, Sebastian Benthall wrote: > Emailing list for group edification, but mostly for Andreas: > > http://github.com/GeoNode/geonode/commit/55c0b999248a273fa3179e7e64e2c021b9dfb411 > > Mad this change to the Ext-based MapGrid. I note it here because I > couldn't figure out a cleaner (event-driven) way to disable the > expander plugin button except the hacky way I did it. > > I think the way the RowExpander is designed makes it much more trouble > than its worth to unbind the 'mousedown' event (the binding of the > rowToggle behavior to the mousedown event happens when the grid's view > is rendered, but the declaration happens when the expander itself is > initialized, so the timing is tricky--i tried!). But I wanted to > invite your review in case you see a better way to do it that escaped me. > > -- > Sebastian Benthall > OpenGeo - http://opengeo.org >
