On 07/12/2010 03:39 PM, Sebastian Benthall wrote: > Been working on this branch: > http://github.com/sbenthall/geonode/commits/mapmetadata > > On this ticket: > http://projects.opengeo.org/CAPRA/ticket/595 > > It's mostly JavaScript. Reviews/comments welcome. > > Will continue working on related tickets: > http://projects.opengeo.org/CAPRA/ticket/594 > http://projects.opengeo.org/CAPRA/ticket/596 > http://projects.opengeo.org/CAPRA/ticket/630 > > -- > Sebastian Benthall > OpenGeo - http://opengeo.org > The main thing I noticed looking at this was that i18n is not being used for a lot of the strings added. Haven't tried running it though.
Side note (I brought this up in channel but the list is more permanent): github's branch comparison view is pretty nice, but it can only compare within a single repository. Therefore, it's a little handier for reviewers if you keep the master branch in your fork up to date when you've merged changes from origin/master into a feature branch. Otherwise, changes that are in origin/master, but not sbenthall/master, will show up in the branch comparison view. "gitk contributer/feature ^origin/master" works pretty well too, though. -- David Winslow OpenGeo - http://opengeo.org/
