That said, option 2 is fine with me. If we find we are getting
conflicts, we can always back out to option 1 later.
P
Paul Ramsey wrote:
The usual issues apply to putting generated files into the repository:
if different people with different swigs generate these files they will
potentially clobber each other in the repository and even generate
conflicts.
A checks out
B checks out
A generates and updates and commits
B generates and updates, conflict!
P
Charlie Savage wrote:
Hmm...Looks like goes.py is not in SVN (probably wasn't in CVS).
Since it hasn't been generated (by building the SWIG bindings) it blow
up on make dist. Same is going to be true for the .cxx files.
A few choices, which have been discussed previously:
* make needs to build the SWIG bindings, then make dist would work
* these files get added to SVN, so make dist works whether or not you
build the swig bindings. It also means you could compile the SWIG
binding without having SWIG.
* these files don't get added to SVN and don't get distributed,
thereby forcing anyone who downloads GEOS to have SWIG in order to
build the SWIG bindings.
I'd prefer the 2nd choice. What do other think?
Charlie
Mateusz Loskot wrote:
Paul Ramsey wrote:
The deed is done.
http://svn.refractions.net/postgis
http://svn.refractions.net/geos
I'd like to confirm:
- clean checkout - works
- autogen.sh/configure - works
- make - works
- make check - works
- make dist - does not work
Here is the error message I get when running 'make dist':
make[2]: Entering directory
`/home/mloskot/dev/geos/_svn/geos/swig/python'
make[2]: *** No rule to make target `geos.py', needed by `distdir'.
Stop.
make[2]: Leaving directory
`/home/mloskot/dev/geos/_svn/geos/swig/python'
make[1]: *** [distdir] Error 1
make[1]: Leaving directory `/home/mloskot/dev/geos/_svn/geos/swig'
make: *** [distdir] Error 1
Best regards
------------------------------------------------------------------------
_______________________________________________
geos-devel mailing list
geos-devel@geos.refractions.net
http://geos.refractions.net/mailman/listinfo/geos-devel
_______________________________________________
geos-devel mailing list
geos-devel@geos.refractions.net
http://geos.refractions.net/mailman/listinfo/geos-devel
_______________________________________________
geos-devel mailing list
geos-devel@geos.refractions.net
http://geos.refractions.net/mailman/listinfo/geos-devel
