Thanks for the update, J Let me know when you need some testing --strk;
On Mon, May 02, 2016 at 10:32:17AM -0400, J Smith wrote: > G'day list. > > Just a quick update on the GEOS PHP bindings. I took some time last > night to take a look at PHP 7 and did a quick migration to their new > API. I'm able to compile cleanly and some of the tests are running, > although I need to sort through the individual methods and clean up > some bits and pieces here and there. Most of the pain at this point > involves changes to the way PHP 7 manages memory and moving over to > new data types like zend_string where it makes sense. It's definitely > a decent start, even if it's a bit rough at the moment. Once I get > everything stabilized I'll look into abstracting some of the changes > away into some macros and the like so that both PHP 5 and 7 can > compile from the same code base, as right now I've torn things apart > for the sake of getting to know PHP 7 a bit better. The major hang up > at the moment is the new memory management system, as I'm experiencing > segfaults at process shutdown and with garbage collection, but it's > nothing that's insurmountable, just some basic refactoring and > rejiggering that's necessary. I'll have some more time available soon > to try and wrap up a first pass, after which the abstractions will > come in. > > Cheers, list. > > On Mon, Mar 21, 2016 at 5:15 AM, Sandro Santilli <s...@keybit.net> wrote: > > On Sun, Mar 20, 2016 at 07:48:46PM -0400, J Smith wrote: > >> On Thu, Mar 10, 2016 at 5:02 PM, Sandro Santilli <s...@keybit.net> wrote: > >> > > >> > Also, the "make check" run ends with prompting me, which is really > >> > annoying. The prompt asks if I want to send the report to the PHP QA > >> > team. Really ? Should we send successful test run reports for a single > >> > package to "the PHP QA team" ?? I wouldn't want to be in that team :) > >> > > >> > >> Yeah, that's annoying. All part of the standard test suite for PECL > >> extensions. :/ > >> > >> How about this... > >> > >> - I'll make the tests spit out more output on success so we know > >> things are working fine. Likewise when there's a problem, it'll be > >> more obvious what failed. > > > > I actually like the output to be short and clean on success > > (just a short report of how many tests were run). This wasn't > > the case IIRC. > > > > Can't comment on the quality of failure reports as if I understood > > correctly there was no failure in my run. > > > >> - I'll see what I can do about `make check`, have it not prompt > >> anything. I'll leave `make test` as-is because that's the standard > >> PECL testing command and there might be some dependencies on it > >> behaving that way, but `make check` shouldn't have any similar > >> dependencies since it's an OSGEO-thing I assume, right? > > > > 'make check' can be just an alias for 'make note'. > > > >> On another note, I'll be looking into PHP7 compatibility. I took an > >> initial look about a month ago, doesn't look too bad, but it'll take > >> it some time I figure. > > > > Great, thanks ! > > > > --strk; _______________________________________________ geos-devel mailing list geos-devel@lists.osgeo.org http://lists.osgeo.org/mailman/listinfo/geos-devel
