#1015: Update geos-config tool for consistency -----------------------------------+-------------------------- Reporter: robe | Owner: geos-devel@… Type: defect | Status: new Priority: minor | Milestone: 3.9.0 Component: Build/Install (cmake) | Version: master Severity: Unassigned | Keywords: -----------------------------------+-------------------------- Details repeated from https://git.osgeo.org/gitea/geos/geos/pulls/99
---- **Specify bash, and use printf to escape paths (if needed)** This allows installation with CMake to other directories, such as `/opt/my prefix`, since `geos-config --prefix` would return `/opt/my\ prefix`. Also `printf` is a bash-only feature. **Restore bash variables, e.g. `${prefix}`, and use CMake's `@ONLY` option ** Restore to prior syntax in b15fd1171823d16195bee17f2c7b44778603258d using `${prefix}` rather than substituting `@CMAKE_INSTALL_PREFIX@`. Re-use variables throughout script for convenience. Note that the current autotools setup does not fully install to prefixes that need escaping, but the CMake setup can. **Consistent indents and style between .in and .cmake versions** Use 2-space indents, re-order case statements to same order as usage. The Autotools and CMake versions are nearly the same, with the exception of Autotool's `libdir`, which perhaps could be something other than `$prefix/lib`? **Remove `exec_prefix`, which has never been used** Checking the history of this file, it does not seem to be used. **Disable configure and install for MSVC builds** The script requires bash, which is not used for MSVC. Scheme to install a MSVC version of `geos-config.bat` is drafted at [trac#1014](#1014). ---- -- Ticket URL: <https://trac.osgeo.org/geos/ticket/1015> GEOS <http://trac.osgeo.org/geos> GEOS (Geometry Engine - Open Source) is a C++ port of the Java Topology Suite (JTS).
_______________________________________________ geos-devel mailing list geos-devel@lists.osgeo.org https://lists.osgeo.org/mailman/listinfo/geos-devel