Andrea Aime ha scritto:

> I've attached the latest version of that junit3 based thing.
> Plan:
> * have GeoServerAbstractTestSupport extend OneTimeSetupTest and
>   implement the one time setup/teardown (any idea
>   for a better name for the one time test supeclass? And no, I won't
>   accept WWWTest as a candidate... no, TestWWW does not count either
>   :) )
> * change all tests setup/teardown to setupInternal/teardowninternal
> * add the suite() method to the read only test classes

I've done a quick test by changing the geoserver classes.
The good: a sample test like GetCoverageTest goes down from 16 to 9
seconds.
The bad: the suite() method has to be defined in each class that
can run in "one time setup" mode
The ugly: every setup method has to be modified into setUpInternal,
and you have to remember not to call super.setUp() or an infinite
recursion triggers. We should come up with a way to throw an
exception if this happens and tell the user that he should
call super.setupInternal instead

Still wondering if I should turn this into a proposal.
Cheers
Andrea

-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference 
Don't miss this year's exciting event. There's still time to save $100. 
Use priority code J8TL2D2. 
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Reply via email to