On Friday 27 June 2008 08:22:19 pm Justin Deoliveira wrote: > > Ok, so to make sure I would still have to try and connect to the > > datastore and then check for error message. Like, I cannot be sure > > an attempt to connect already occurred? (or can I?) > > Well I was more thinking that if getError() was non-null you would mark > it was an error. Then if say the user changes a parameter you then try > again (ie, call getDataStore()). Under the hood the resorucePool would > then re-connect and clear the error if the connection was successul. > Then I guess you would have to update the icon. I beleave at the time of writing the datastore configuration page I didn't know the datastore shall be acquired through StoreInfo.getDataStore and hence I'm using DataStoreFinder directly with the Map of parameters set in the form. This missunderstanding may lead to conflicts in the intended workflow. For instance, I seem to remember wasn't able to edit the configuration for a datastore that became invalid (say, wrong server ip or whatever avoids from connecting to the backend), so there may not be a way to edit datastore parameters when they're invalid... It seems to be the datastore page should only deal with StoreInfo and avoid accessing the actual DataStore as much as possible, or at least let StoreInfo.getDataStore() to lazily do it, right? That's one thing that should be fixed I guess.
Gabriel > > > Cheers > > Andrea > > > > ------------------------------------------------------------------------- > > Check out the new SourceForge.net Marketplace. > > It's the best place to buy or sell services for > > just about anything Open Source. > > http://sourceforge.net/services/buy/index.php > > _______________________________________________ > > Geoserver-devel mailing list > > [email protected] > > https://lists.sourceforge.net/lists/listinfo/geoserver-devel ------------------------------------------------------------------------- Check out the new SourceForge.net Marketplace. It's the best place to buy or sell services for just about anything Open Source. http://sourceforge.net/services/buy/index.php _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
