Andrea Aime wrote:
> Justin Deoliveira ha scritto:
>   
>> Hi all,
>>
>> Dwins and I again today ran into the indeterministic test problem in 
>> which were both getting failures on trunk in different instances. And it 
>> was again indeed a result of initializing the crs subsystem.
>>
>> The failures on my part were resulting only in eclipse. I am still 
>> unsure of the root cause but I found a fix by changing the following in 
>> GeoServerAbstractTestSupport:
>>
>> if 
>> (Boolean.TRUE.equals(Hints.getSystemDefault(Hints.FORCE_LONGITUDE_FIRST_AXIS_ORDER)))
>>  
>> {
>>    Hints.putSystemDefault(Hints.FORCE_AXIS_ORDER_HONORING, "http");
>> }
>>
>> The change is to remove the guard around setting the 
>> FORCE_AXIS_ORDER_HONORING hint, and always setting it. The result is 
>> that all tests pass in eclipse.
>>
>> So my questions are for Andrea (i think):
>>
>> 1. What is the rationale behind checking the default for the 
>> FORCE_LONGITUDE_... hint before setting the FORCE_AXIS_... hint.
>>
>> 2. What are the repercussions of always setting the FORCE_AXIS_... hint?
>>     
>
> The code is thought out so that if someone want GeoServer to operate
> in EPSG native mode (lat before lon) he can. That requires the user to 
> just set up a system variable stating that he does not want the
> FORCE_LONGITUDE_FIRST_AXIS_ORDER to be honoured. In that case, also
> the FORCE_AXIS_ORDER_HONORING should be avoided.
>
> Since this feature is not exactly at the top of our users demands
> (no one ever asked about it that I can remember),
> we can just forget about it and force lon/lat order and friends
> all the way.
>
> Cheers
> Andrea
>
>   
It's probably worth noting that the check Justin refers to is in 
GeoServerAbstractTestSupport, so we can remove it without changing code 
that is shipped as part of a GeoServer release.  Since we want the tests 
to be consistent, it's probably a good thing to remove conditionals from 
the setup code, right?

-d

-------------------------------------------------------------------------
This SF.Net email is sponsored by the Moblin Your Move Developer's challenge
Build the coolest Linux based applications with Moblin SDK & win great prizes
Grand prize is a trip for two to an Open Source event anywhere in the world
http://moblin-contest.org/redirect.php?banner_id=100&url=/
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Reply via email to