Justin Deoliveira ha scritto: > Hi all, > > I have created an interface for the life cycle of a dispatcher request > as per the discussion for http://jira.codehaus.org/browse/GEOS-2333. I > have attached the interface and dispatcher patch to a new issue: > > http://jira.codehaus.org/browse/GEOS-2402 > > A code review would be nice. Thanks.
The DispatcherCallback seems pretty complete. Afaik the callback can alter everything in the request, but not the object returned from dispatching. Say that you may want to wrap it, or swap it solid with something else, what about that? Also, I see no place for exceptions. One thing that we may want to do is to add request validation, such as refusing WMS requests whose size is more than 1000x1000, of WFS validation, say you have a huge data set and don't want people to download it fully, so you want to check they added a bbox filter and/or an attribute filter. Stuff like that seems like a good fit for this callback, and I guess they would throw an exception. Hmm... service exceptions are runtime exceptions, so no need to declare them, but making it explicit would help from a documentation point of view. Just as a style thought, wouldn't it be nicer to have a separate class dealing with forwarding all of the messages to listeners rather than having all the fireXXX methods sprinkled around in the dispatcher (which is quite big already)? Anyways, not a big deal. Cheers Andrea -- Andrea Aime OpenGeo - http://opengeo.org Expert service straight from the developers. ------------------------------------------------------------------------- This SF.Net email is sponsored by the Moblin Your Move Developer's challenge Build the coolest Linux based applications with Moblin SDK & win great prizes Grand prize is a trip for two to an Open Source event anywhere in the world http://moblin-contest.org/redirect.php?banner_id=100&url=/ _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
