Question. Is everything under org.geoserver.web.wicket intended to be 
totally generic? Or just any component used in more than once place? The 
reason i ask is because browsing through the directory I see the class 
"WorkspaceChoice", which makes me think that common widgets/controls for 
the catalog will go under this structure.

I wonder if this this wise. My first impression would be to keep widgets 
specific to the catalog under "web.data". The reason being that i can 
see the common widget directory quickly exploding with classes if we 
start putting everything that is reusable in there.

My preference would be to draw the line at re-usable widgets which 
"cross cut" sub systems. ie widgets that will probably be used for 
catalog pages, configuration pages, service pages, etc...


Andrea Aime wrote:
> Justin Deoliveira ha scritto:
>> +1, the organization makes sense to me.
>>
>> Andrea Aime wrote:
>>> Hi,
>>> trying to write out more panels for the new Wicket
>>> UI it's evident I'm growin a (small) number of reusable
>>> classes, in terms of:
>>> - UI components
>>> - models (as in IModel), especially loadable catalog object wrappers
>> I noticed this too... a nice convenient base class would be nice for 
>> loadable detachable models for catalog objects. Could look up the id 
>> reflectively, and then just call a subclass hook to do the actual 
>> lookup. Is that what you had in mind?
>>> - validators
>>> - converters (not right now, but I was about to develop one today)
>>>
>>> At the moment we have the org.geoserver.web.wicket package hosting
>>> the reusable components, but nothing specific for the others.
>>> What about the following structure instead:
>>>    org.geoserver.web
>>>        component
>>>        model
>>>        validator
>>>        converter
> 
> I was about to make this change and realized this proposed change
> would split the 4 packages across the package tree, instead of keeping
> them close.
> 
> What about:
>     org.geoserver.web.wicket
>         component
>         model
>         validator
>         converter
> 
> One more nesting level, but also a single place for Wicket reusable
> stuff. Better?
> 
> Cheers
> Andrea


-- 
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

------------------------------------------------------------------------------
Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are
powering Web 2.0 with engaging, cross-platform capabilities. Quickly and
easily build your RIAs with Flex Builder, the Eclipse(TM)based development
software that enables intelligent coding and step-through debugging.
Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Reply via email to