Hi, I've been tasked to go through the i18n stuff for Wicket again. But I think we need to lay down the ground rules before I edit any further.
1) Our i18n framework? http://jira.codehaus.org/browse/GEOS-2707 mentions the need to document "our custom i18n framework (how to use it)" What is meant by "our i18n framework" ? ( In contrast to the one wicket ships with.) Plugin support ? 2) Message ids Example: wfs.maxFeatures = Per-Request Feature Limit maxFeatures = Maximum number of features This strikes me as arbitrary and makes it difficult to translate the application. The only way we can avoid this is if the key actually contains the entire message. Without getting into a discussion about the path prefix, I think the above should be: wfs.perRequestFeatureLimit maximumNumberOfFeatures Agreed? I'm not sure what to do about really long strings. 3) Message id prefixes Example: "geosearch.enable" in web2/wms/src/main/java/org/geoserver/wms/web/publish/GeoSearchLayerConfigPanel.htm vs "wms.data.style.name" in web2/wms/src/mainjava/org/geoserver/wms/web/data/StyleEditPage.html The WFS module doesn't seem to use paths at all. Regardless of what is currently used in the code (it varies), do we have an idea of how we want to do the paths for messages? 4) Random submit buttons: Example: <input type="submit" value="Submit!"></input> in web2/wms/src/main/java/org/geoserver/wms/web/publish/WMSLayerConfig.html Are those leftovers from when we were doing a tab-intensive design? Should they just be deleted, or am I missing something? 5) Syntax for labels A few places we use <label for="maxFeatures"><wicket:message ... What does the for="maxFeatures" do, and do we want it for all labels ? It's used some places, but far from all. That's all for now, I'm sure there will be more, -Arne -- Arne Kepp OpenGeo - http://opengeo.org<input type="submit" wicket:message="value:page.search"/> Expert service straight from the developers ------------------------------------------------------------------------------ This SF.net email is sponsored by: High Quality Requirements in a Collaborative Environment. Download a free trial of Rational Requirements Composer Now! http://p.sf.net/sfu/www-ibm-com _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
