Gabriel Roldan ha scritto: > Hey all, > > I've been getting hands dirty with the wicket UI finally and would like > to comment on some stuff. > I have refactored web.data.datastore and web.data.coverage into a single > package web.data.store as the pages are about configuring the StoreInfo > classes, not DataStore/CoverageStore. > Am also splitting out the concrete store pages from a single page to > add/edit into separate pages both to follow naming convention > FooNewPage/FooEditPage and to avoid a single class having two > responsibilities. > While in the process found that both DataStoreInfo and CoverageStoreInfo > new/edit pages completely lacked unit tests, so I also started adding > them, since they're quite buggy when not on the everything-goes-fine use > case, and also catched on some non tested behaviour about the switch to > use real identifiers instead of name as id on the catalog objects.
Yeah, we did schedule full test coverage for after the 2.0alpha2 release, along with a raft of cosmetic improvements: http://jira.codehaus.org/browse/GEOS-2704 The first part of the effort was to get the UI going for the working case, that alone was quite an effort, nothing in the existing configuration pages was actually working at all. > Also found some cross references between packages that I would like to > avoid. For instance, the package ...web.data contains all the resource > configuration pages as well as the packages for configuring layer, > layergroup, store, workspace and style. > I would like to move the resource configuration pages to a new > data.resource subpackage so the data package interface gets clean. > Another change would be to move the NewDataPage to the store package > since it is only referenced by the store package and then NewDataPage > references classes back in the store package. > > So, any objection about those changes? am I missing something? No objections here, just make sure to coordinate with Justin for the next alpha release (wasn't that scheduled this week?) Cheers Andrea ------------------------------------------------------------------------------ This SF.net email is sponsored by: High Quality Requirements in a Collaborative Environment. Download a free trial of Rational Requirements Composer Now! http://p.sf.net/sfu/www-ibm-com _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
