ModificationProxy does not maintain equals/hashcode contract of the wrapped 
objects
-----------------------------------------------------------------------------------

                 Key: GEOS-3051
                 URL: http://jira.codehaus.org/browse/GEOS-3051
             Project: GeoServer
          Issue Type: Bug
          Components: Configuration
            Reporter: Andrea Aime
            Assignee: Justin Deoliveira
             Fix For: 2.0-beta1


As the title says, it seems it does not delegate the above two methods. I 
noticed this in the CascadeRemovalReporter, I have a map that should collect 
the groups and the layers removed so that I know, at the end of the visit, if 
the group is to be removed or just updated. Unfortunately the same group ends 
up in the map multiple times because, I guess, different proxies are created 
out of it and the equals/hashcode is not delegated to the wrapped object (but 
I'm not sure, so take this with a pinch of salt, I did not really check if the 
equals/hashcode methods are not being delegated, if they are but the compared 
proxy is not being unwrapped, or whatever might be the actual reason).
Note that the equals/hashcode of the catalog objects is probably better 
computed out of the ID alone, if we have properties involved, the modification 
proxies might be buffering some changes that would make the equality between 
different proxies work in an inconsistent way.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Crystal Reports - New Free Runtime and 30 Day Trial
Check out the new simplified licensing option that enables 
unlimited royalty-free distribution of the report engine 
for externally facing server and web deployment. 
http://p.sf.net/sfu/businessobjects
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Reply via email to