It all looks great. The only two very minor mods i had to make where:

1) Change the groupId to org.geoserver.extension in the pom.xml of 
feature-pregen

        <version>1.7.5-SNAPSHOT</version>
    </parent>

-  <groupId>org.geoserver</groupId>
+  <groupId>org.geoserver.extension</groupId>
    <artifactId>feature-pregeneralized</artifactId>
    <packaging>jar</packaging>
    <version>1.7.5-SNAPSHOT</version>

2) Add an include entry to the artifact descriptor for the geoserver lib


        <directory>release/target/dependency</directory>
        <outputDirectory></outputDirectory>
        <includes>
+        <include>feature-pregeneralized-*.jar</include>
          <include>gt-feature-pregeneralized-*.jar</include>
        </includes>
        <excludes>

Great work :)

Aside, I guess we should add this to the list of extensions that need to 
be ported to trunk.

-Justin

Christian Müller wrote:
> I checked in the move from communtiy module to extension module . My 
> local hudson based on an ibm 6.0  jdk executes a build without errors.
> Anyway, could you take a short look if anything is ok ?
> 
> Justin Deoliveira writes:
>> It should be pretty much identical. Since the feature-pregeneralized 
>> community module (soon to be an extension) declares a maven dependency 
>> on gt-feature-pregeneralized, it will get dragged in.
>> The only difference will be in the 
>> release/ext-feature-pregenerialized.xml release artifact descriptor. 
>> YOu just need to configure it to grab both of the jars.
>> Does that make sense. I am happy to help setting it up. I realize 
>> there are a couple of tricky steps.
>> -Justin
>> Christian Müller wrote:
>>> Yes, I did the the same thing with imagemosaic-jdbc which was 
>>> completely taken from geotools. 
>>> The difference is that there are 2 modules 
>>> gt-feature-pregeneralized  from geotools
>>> feature-pregeneralized  from geoserver 
>>> which are tied together. 
>>> Should I make 2 independent extensions ?. That could be confusing. 
>>>  
>>>  
>>>
>>> Justin Deoliveira writes: 
>>>> I guess the next logical step is to upgrade it to an extension as 
>>>> outlined here: 
>>>> http://geoserver.org/display/GEOS/GSIP+22+-+Community+Modules 
>>>> Basically: 
>>>> 1) moving the module
>>>> 2) updating all the relevant pom.xml and profiles
>>>> 3) add a release artifact descriptor for it 
>>>> I believe you went through the process for imagemosaic-jdbc? 
>>>> -Justin 
>>>> Christian Müller wrote:
>>>>> I finshed the geoserver tutorial for the feature-pregeneralizd module.
>>>>> http://docs.geoserver.org/1.7.x/user/tutorials/feature-pregeneralized/f 
>>>>> ea tur e-pregeneralized_tutorial.html
>>>>> (at the moment of writing this email, it is not up to date, but it 
>>>>> is already commited)  
>>>>> For testing the tutorial, the gt-feature-pregneralizd-<version>.jar 
>>>>> from geotools/plugin and  the
>>>>> feature-pregeneralized-<version>.jar from the geoserver community 
>>>>> module must be in WEB-INF/lib.  
>>>>> What are the next steps ? 
>>>>> ----------------------------------------------------------------------- 
>>>>> -- -----
>>>>> Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT
>>>>> is a gathering of tech-side developers & brand creativity 
>>>>> professionals. Meet
>>>>> the minds behind Google Creative Lab, Visual Complexity, 
>>>>> Processing, & iPhoneDevCamp asthey present alongside digital 
>>>>> heavyweights like Barbarian
>>>>> Group, R/GA, & Big Spaceship. http://www.creativitycat.com 
>>>>> _______________________________________________
>>>>> Geoserver-devel mailing list
>>>>> [email protected]
>>>>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>>>>  
>>>> -- 
>>>> Justin Deoliveira
>>>> OpenGeo - http://opengeo.org
>>>> Enterprise support for open source geospatial.
>>>  
>>>
>>> ------------------------------------------------------------------------- 
>>> -----
>>> Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT
>>> is a gathering of tech-side developers & brand creativity 
>>> professionals. Meet
>>> the minds behind Google Creative Lab, Visual Complexity, Processing, 
>>> & iPhoneDevCamp asthey present alongside digital heavyweights like 
>>> Barbarian
>>> Group, R/GA, & Big Spaceship. http://www.creativitycat.com 
>>> _______________________________________________
>>> Geoserver-devel mailing list
>>> [email protected]
>>> https://lists.sourceforge.net/lists/listinfo/geoserver-devel
>>  
>>
>> -- 
>> Justin Deoliveira
>> OpenGeo - http://opengeo.org
>> Enterprise support for open source geospatial.
> 
> 


-- 
Justin Deoliveira
OpenGeo - http://opengeo.org
Enterprise support for open source geospatial.

------------------------------------------------------------------------------
Register Now for Creativity and Technology (CaT), June 3rd, NYC. CaT
is a gathering of tech-side developers & brand creativity professionals. Meet
the minds behind Google Creative Lab, Visual Complexity, Processing, & 
iPhoneDevCamp asthey present alongside digital heavyweights like Barbarian
Group, R/GA, & Big Spaceship. http://www.creativitycat.com 
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel

Reply via email to