Andrea Aime wrote:
> Gabriel Roldan ha scritto:
>> hey,
>>
>> when you have a second could you please take a look at the patch at
>> http://jira.codehaus.org/browse/GEOS-3106.
>> Asking for review 'cause though I think it is what we just agreed, it
>> touches the interfaces so a review would be handy.
>
> Gabriel, thanks for uploading a patch for review. It looks good to me.
cool, gonna commit then.
>
> I was wondering if we should add a enabled() to StoreInfo as well that
> checks if the store is actually reachable. This could in turn be used
> in http://jira.codehaus.org/browse/GEOS-3049 to avoid failures in
> WFS requests (when one ft cannot be computed properly WFS requests
> that need to setup a gt-xsd parser fail during the parser config setup).
I'm not sure I fully understand the issue. You mean if a ft _unrelated_
to the request under execution can't be computed? if so, it shouldn't,
ok. If the ft is related to the request (say a request involving more
than one ft) the request should obviously fail.
By the patches at GEOS-3049 it seems you're in need for an enabled()
method in FeatureTypeInfo and StoreInfo?
only concern is if it's gonna scale. Right now the enabled() derived
property does not check for actual resource availability, just cascades
the isEnabled() property. But if we get to force the acquisition of the
DataStore/FeatureType I'm not sure how well it'll behave UI lists wise
(though yeah, when it comes to scaling to thousand of layers we'll have
to implement some sort of deferred list loading that plays well with
paging).
So what about this: keep enabled() being just a configuration concern,
no I/O nor exceptions involved, and add a reachable() property that
checks the involved resource (featuretype, datastore, coverage reader)
is actually accessible? This one should be used in more constrained
situations (non bulk) and may avoid a lot of try{get to the resroucepool
and grab the resource}catch(resource pool complains){}
does that make sense?
>
> Cheers
> Andrea
>
--
Gabriel Roldan
OpenGeo - http://opengeo.org
Expert service straight from the developers.
------------------------------------------------------------------------------
OpenSolaris 2009.06 is a cutting edge operating system for enterprises
looking to deploy the next generation of Solaris that includes the latest
innovations from Sun and the OpenSource community. Download a copy and
enjoy capabilities such as Networking, Storage and Virtualization.
Go to: http://p.sf.net/sfu/opensolaris-get
_______________________________________________
Geoserver-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/geoserver-devel
