Andrea Aime wrote: > Justin Deoliveira ha scritto: >> One thing i just thought of is mangling that has to occur dynamically. >> Perhaps based on a request parameter. Currently by using only string >> registered url manglers it seems that urls could only really be mangled >> staticaly. >> >> Anyways, not a -1 or anything, just a thought. And probably something >> that could be solved by simply overloading buildURL() to take a >> URLMangler as an optional parameter. > > What is the use case of passing a custom mangler besides the one > already registered in the spring context? I guess I don't have one really. Just thought that a mangler registered in a spring context will be relatively static, and not have access to dynamic info like request parameters, etc...
It also might be a bit cleaner to have service code explicitly invoke a mangler in a conditional case, rather than have the mangler registered, and have it check that case. And in that case the mangler might not have the relevant information to check the condition. Like maybe its perhaps something that based on the value of a format option. Anyways, probably something best tabled for now, and we can revisit it if it does indeed turn out to be a limitation. >> Also, in terms of naming i think URLMangler.mangleUrl should change to >> mangleURL() to match buildURL(). > > Right. > >> Updated GSIP with a +1 vote. > > Thanks > > Cheers > Andrea > -- Justin Deoliveira OpenGeo - http://opengeo.org Enterprise support for open source geospatial. ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
