Andrea Aime wrote: > Justin Deoliveira ha scritto: >> Hi all, >> >> Apologies if I missed something while I was away but I thought before we >> more or less agreed that we would adopt Mike as the user guide doc >> maintainer and that non-trivial changes should go through him via patches? > > For minor changes and 1-1 copies from the wiki I committed right > away and asked Mike to review in the relevant jiras.
Hmmm... minor changes i would agree require no review, but straight copies from the wiki i would disagree. The reason being that part of the port from the wiki to sphinx has been quality control on the docs. > I remember we talked about asking for reviews, not that the rule was > to have a review before the commit. > Btw, I've tried pre-commit reviews too and I had some > patches linger on the jira for weeks... 3 weeks and counting > for this one for example: http://jira.codehaus.org/browse/GEOS-3339. > So for smaller stuff I've started to just commit and ask for a post > review. Fair enough. I know that not everyone watches jira as closely as some. We should ask mike if he is actually getting notification of these patches? > > Cheers > Andrea > -- Justin Deoliveira OpenGeo - http://opengeo.org Enterprise support for open source geospatial. ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
