Big patch no doubt :) Just went through it and it looks really good. Much cleaner result.
One question I have is about the request base url. It seems a lot of code before was proxifying the base url as soon as it was grabbed from the request. But now the pattern is to just build/mangle the url only when it needs to be encoded. Nice change, just those who are writing service code need to keep the paradigm shift in mind. I made some comments on the issue. -Justin Andrea Aime wrote: > Hi, > for your 130k diff reviewing pleasure you can find the patch for trunk > attached here: > http://jira.codehaus.org/secure/ManageAttachments.jspa?id=96855 > > I've tested it a bit, seems to work fine, all tests are passing > and running GS behind a proxy works too (minus the authentication > in the GUI, but that's a separate issue... and something I think > we've already seen in 1.7.x) > > Cheers > Andrea > -- Justin Deoliveira OpenGeo - http://opengeo.org Enterprise support for open source geospatial. ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
