Hi all, I took the hibernate catalog for a quick test spin tonight.
First off great work, it is so nice to see this actually taking shape. Here is my first round of feedback. From a brief code inspection: * package org.geoserver.catalog.hibernate The only issue i see here is quite a bit of duplication with the regular CatalogImpl class. I wonder if there is any possibly of subclassing, or factoring out a common super class. IT would be nice to do so and handle all things like event dispatch, validation (especially since there is a push to stick more validation logic directly into the catalog), etc... * package org.geoserver.catalog.hibernate.beans * package org.geoserver.config.hibernate.beans So it seems most of the InfoImpl objects are subclassed with a hibernate version. In some cases i notice that the subclass does not really do anything except for add a serialVerionUID. In some cases it just adds a getter and setter for id. I am wondering if we can pull all of this up into the default impl objects? Or is there another reason why we require a subclass per object? Thinking mostly about maintainence here, adding new types to the catalog is already a bit of a pain due to adding the interface, the impl class, and any decorators needed. Code aside, i actually ran GeoServer, and it started up nicely. Imported my styles, and my workspaces. But nothing else. No resources, stores or layers. I will admit i did not dig in very hard. Once again great work guys. -Justin -- Justin Deoliveira OpenGeo - http://opengeo.org Enterprise support for open source geospatial. ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
