I did not review the patch in too much detail but it looks sensible given the bug report.
One thing though is that it seems this introduces a right way and a wrong way to do linking between pages. It might be good to have this summarized somewhere for wicket novices such as myself. Andrea Aime wrote: > Hi, > today I've been working out a patch for > http://jira.codehaus.org/browse/GEOS-3401 > > The patch tries hard to remove all inter-page ajax links and > replace them with bookmarkable ones, resulting in links that > survive a sessions timeout, a server restart, and that can > be bookmarked. > The patch itself is not small, so if anyone wants to give it > a look, it would be appreciated. > > Once that is in we have to find a way to get something better looking > than: > http://localhost:8080/geoserver/web/?wicket:bookmarkablePage=:org.geoserver.wms.web.data.StyleEditPage&name=pophatch > > We already discussed this in the past: > http://old.nabble.com/Nice-URLs-in-Wicket-to18128232.html#a18128232 > http://old.nabble.com/Clean-up-Wicket-URLs%2C-part-two-td24427423.html > > The final solution was the idea of registering something in the > Spring context that would make the page be mounted following > certain contentions. > > Just today I stumbled into these annotations that would basically > allow us to specify the mount point in the class itself: > http://wicketstuff.org/confluence/display/STUFFWIKI/wicketstuff-annotation > > On one side it seems handier than declaring the mount path in > xml. On the other side, we'd start to have two sources for page > information, the spring files for menu entries, and the annotations > for the rest. > And oh, the above annotations would make us write the mount point > explicitly instead of following a convention (but I guess if we > really wanted we could roll our own annotations with no > parameters, something like @MountPage) > > What do you think? What is the best path forward? > > Cheers > Andrea > -- Justin Deoliveira OpenGeo - http://opengeo.org Enterprise support for open source geospatial. ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
