Andrea Aime ha scritto: > Justin Deoliveira ha scritto: >> I am not so big on the idea of making the catalog store the default >> workspace under the "default" key and have REST rely solely on that >> assumption. I would rather this be enforced at the catalog api level and >> allow any catalog implementation to represent the default as they choose >> so it can remain an implementation detail. >> >> So I think the following would work: >> >> (a) prevent the user from creating a workspace named "default" and have >> it be truly a reserved identifier >> >> (b) Update the api for Catalog.getWorkspaceByName(String) to handle null >> or "default" as meaning the default workspace. > > Ok... and this far the REST api has not been touched one bit, and it > has already started working as it should (default handling working > everywhere by grace of the catalog doing so). > > Are you suggesting I also add checks everywhere in the REST api for > the "default" keyword? As it seems to be suggested by "have REST rely > solely on that assumption".
Re-reading your message, maybe you just meant that instead of doing that just at the CatalogImpl level we should properly declare at the Catalog javadoc level that "default" is reserved and what its meaning is? Is so I absolutely agree, I wanted to make that in the first place, sorry I was no explicit about it Cheers Andrea -- Andrea Aime OpenGeo - http://opengeo.org Expert service straight from the developers. ------------------------------------------------------------------------------ _______________________________________________ Geoserver-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/geoserver-devel
